Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Putty-Style-Mousebutton-Swap #1071

Merged
merged 12 commits into from
Sep 30, 2023
Merged

Putty-Style-Mousebutton-Swap #1071

merged 12 commits into from
Sep 30, 2023

Conversation

macrl2000
Copy link
Contributor

Hi, i tried this years ago for some ancient branch which made no sense to integrate, but recently hat to redo it for the latest version. i have zero clue if this will break things for you, if it fits in your coding style, or if you like it at all, but i am using this a lot, so i am making this pull request, feel free to deny, modify or use it :-)

this pull request adds the configurable feature that you can swap middle and right mouse button application side.

yan12125
yan12125 reviewed Sep 24, 2023
View reviewed changes
Copy link
Member

@yan12125 yan12125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this nice feature! At first glance it looks good. Just some minor stuffs.

src/mainwindow.cpp Outdated Show resolved Hide resolved
src/properties.cpp Outdated Show resolved Hide resolved
src/termwidget.cpp Outdated Show resolved Hide resolved
src/termwidget.cpp Outdated Show resolved Hide resolved
src/termwidget.cpp Outdated Show resolved Hide resolved
src/termwidget.cpp Outdated Show resolved Hide resolved
src/properties.h Outdated Show resolved Hide resolved
@macrl2000
Copy link
Contributor Author

i pushed the code changes you requested, hope this is all correct now

@yan12125
Copy link
Member

There are some compile errors as shown in https://github.com/lxqt/qterminal/actions/runs/6310403117/job/17137137707. Could you check?

@macrl2000
Copy link
Contributor Author

i had one letter missing in properties.h sorry, i recompiled - should work now

@macrl2000
Copy link
Contributor Author

sorry i need to check what went wrong - i cannot use git correctly :-(

@macrl2000
Copy link
Contributor Author

maybe now ?

@macrl2000
Copy link
Contributor Author

anything left to do for me ? or can you use it now ?

yan12125
yan12125 reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@yan12125 yan12125 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a GUI option, probably in the "Behavior" tag of the preferences dialog.

src/termwidget.cpp Outdated Show resolved Hide resolved
src/termwidget.cpp Outdated Show resolved Hide resolved
src/termwidget.cpp Show resolved Hide resolved
src/termwidget.cpp Outdated Show resolved Hide resolved
src/properties.h Outdated Show resolved Hide resolved
src/termwidget.cpp Outdated Show resolved Hide resolved
src/termwidget.cpp Outdated Show resolved Hide resolved
src/termwidget.h Outdated Show resolved Hide resolved
src/termwidget.h Outdated Show resolved Hide resolved
@macrl2000
Copy link
Contributor Author

Please all add a GUI option, probably in the "Behavior" tag of the preferences dialog.

for this my qt coding skills are not sufficient, you can maybe add yourself or leave it as config-file only

@yan12125 yan12125 merged commit 7100d5a into lxqt:master Sep 30, 2023
1 check passed
@yan12125
Copy link
Member

Here we go!

for this my qt coding skills are not sufficient, you can maybe add yourself or leave it as config-file only

No problem, a GUI option can be added via another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yan12125 yan12125 yan12125 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macrl2000 @yan12125